fix(discord: commands): init - fix allowing multiple inits of same repo

YappyBots · Oct 12, 2017 · a2a3fdf · a2a3fdf
1 parent c62d258
commit a2a3fdf
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/lib/Discord/Commands/GitlabInit.js b/lib/Discord/Commands/GitlabInit.js
@@ -47,9 +47,9 @@ class GitlabInitCommand extends Command {
 
     if (!repository.isGitlab || isPrivate) {
       // GitlabCache.add(repository.repo);
-      let conf = ChannelConfig.FindByChannel(channelid);
-      let doc = conf && conf.repos ? conf.repos.includes(repoFullName) : false;
-      if (doc) return this.commandError(msg, `Repository \`${repository.repo}\` is already initialized in this channel`);
+      const conf = ChannelConfig.FindByChannel(channelid);
+      const exists = conf && conf.repos && conf.repos.includes(repoFullName);
+      if (exists) return this.commandError(msg, `Repository \`${repository.repo}\` is already initialized in this channel`);
       return ChannelConfig.AddRepoToChannel(channelid, repoFullName)
       .then(() => {
         let embed = this._successMessage(repository.repo);
@@ -58,14 +58,12 @@ class GitlabInitCommand extends Command {
     }
 
     return Gitlab.getRepo(repository.repo).then(res => {
-      const repoInfo = res.body;
-      const repoActualName = repoInfo.path_with_namespace;
       const conf = ChannelConfig.FindByChannel(channelid);
-      const doc = conf && conf.repos ? conf.repos.includes(repoActualName) : false;
-      if (doc) return this.commandError(msg, `Repository \`${repoActualName}\` is already initialized in this channel`);
+      const exists = conf && conf.repos && conf.repos.includes(repoFullName);
+      if (exists) return this.commandError(msg, `Repository \`${repository.repo}\` is already initialized in this channel`);
       return ChannelConfig.AddRepoToChannel(channelid, repoFullName)
       .then(() => {
-        let embed = this._successMessage(repoActualName);
+        let embed = this._successMessage(repository.repo);
         return workingMsg.edit({ embed });
       });
     }).catch(err => {