Valkyrienyanko cleanup #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogboydog
commented
Sep 15, 2024
| { | ||
| lineProvider.YarnProject = yarnProject; | ||
| } | ||
| else lineProvider.YarnProject ??= yarnProject; |
There was a problem hiding this comment.
I personally don't prefer if/else without braces, so I'll add them back here.
dogboydog
commented
Sep 15, 2024
| @@ -1291,7 +1286,7 @@ public async Task<CommandDispatchResult> DispatchCommandToNode(Command command, | |||
| /// <inheritdoc cref="DispatchCommandToNode"/> | |||
| /// <param name="command">The text of the command to | |||
| /// dispatch.</param> | |||
| public async Task<CommandDispatchResult> DispatchCommandToNode(string command, | |||
| public static async Task<CommandDispatchResult> DispatchCommandToNode(string command, | |||
There was a problem hiding this comment.
Technically a breaking change, but it's unlikely people were calling this directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #68