-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bevy 0.15 #217
base: main
Are you sure you want to change the base?
Update to Bevy 0.15 #217
Conversation
FWIW: I don't use a lot of the fancy Yarn features, but I patched my game to use this fork for the 0.15 upgrade and it seems to be working perfectly. |
Thanks a bunch! Will review this proper and when I'm a bit less swamped :) |
It looks like 3 of the 4 CI runs have failed because of the mismatched versions. Should we hold the PR until the demo can be updated, or is that ok? Edit: someone in the Discord told me that Sprite3D has been updated, so I'll work on that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just left some nits :)
There are still some CI failures, one due to Clippy lints added in Rust 1.83, one due to unused variables/imports and some test failures. |
As I mentioned in my first comment, I don't understand that test. Do you have any pointers on this? |
To be honest, I'm not really familiar with the tests myself. |
Nearly all tests are taken from the C# / Unity implementation FWIW. I'll look closer into this PR in 2 weeks and give more guidance then. Until then, it might be useful to look at the C# code as a reference :) |
I added your branch to my project with When adding the plugin with .add_plugins(YarnSpinnerPlugin::with_yarn_source(YarnFileSource::folder(
"events/dialogues",
))) I have about 13 FPS. Using I don't have |
I tested the yarnspinner demo project from @wiggleforlife s branch: I have about 21FPS on there. |
In the diff of this PR I don't see any obvious thing which could impact performance like this... We might need to do a deeper analysis to track down what's causing these issues. |
I tried 4 hours creating a flamegraph and doing traces, to no avail. I doubt that bevy is the issue, I don't think this crate would be the first to notice it and there are no open issues regarding performance, I think it more likely that something was missed during migration |
I was able to create flamegraphs for the two versions, but I'm struggling
to analyse them as well. Not sure if I've noticed performance differences
though - I haven't run with a frame rate counter yet. I've been busy as
well 🙃
…On Fri, 13 Dec 2024, 07:32 tigerplush, ***@***.***> wrote:
I tried 4 hours creating a flamegraph and doing traces, to no avail.
I don't understand where it's coming from (or even how to measure
performance in a definitive way)
I doubt that bevy is the issue, I don't think this crate would be the
first to notice it and there are no open issues regarding performance, I
think it more likely that something was missed during migration
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALAWUVQ3LYXIYRCZDHJZOSD2FL4YZAVCNFSM6AAAAABS2OXG4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRG4YDQOJZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I should state that Framerate drops only happen in develop, not in release profile 🤔 |
Potentially not the best code ever. I didn't update the demo as it depends on https://github.com/FraserLee/bevy_sprite3d, which hasn't been updated.
crates/bevy_plugin/tests/test_strings_tables.rs:142
fails, but I'm not really sure what is happening in the test in the first place, so some assistance would be nice :).