allow overwriting array methods even on frozen objects

YousefED · Dec 19, 2023 · 0a9e1f1 · 0a9e1f1
1 parent 7234609
commit 0a9e1f1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/core/src/array.ts b/packages/core/src/array.ts
@@ -132,7 +132,11 @@ function arrayImplementation<T>(arr: Y.Array<T>) {
 
   const ret = [];
   for (let method in methods) {
-    ret[method] = methods[method];
+    Object.defineProperty(ret, method, {
+      value: methods[method],
+      writable: true,
+      configurable: true
+    })
   }
 
   // this is necessary to prevent errors like "trap reported non-configurability for property 'length' which is either non-existent or configurable in the proxy target" when adding support for ownKeys and Reflect.keysx