Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for launching Firefox >= 129 #336

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Fix logic for launching Firefox >= 129 #336

merged 6 commits into from
Sep 14, 2024

Conversation

YusukeIwaki
Copy link
Owner

@YusukeIwaki YusukeIwaki commented Sep 12, 2024

resolves #335

Known issues:

The example code

page.goto('https://github.com/', wait_until: 'domcontentloaded')
page.wait_for_selector('[placeholder="Search or jump to..."]').click

raises an error "Evaluation failed: {"text"=>"call to Function() blocked by CSP"}"

This bug is also reprodusiblae with Puppeteer (JS) using Firefox on CDP.
https://bugzilla.mozilla.org/show_bug.cgi?id=1650112

@YusukeIwaki
Copy link
Owner Author

It seems some site blocks evaluating JavaScript, however almost works.
https://github.com/user-attachments/assets/f3ebceff-c0d6-433f-9008-05b63370951f

@YusukeIwaki YusukeIwaki marked this pull request as ready for review September 14, 2024 00:18
@YusukeIwaki YusukeIwaki merged commit 7bd632c into main Sep 14, 2024
3 of 12 checks passed
@YusukeIwaki YusukeIwaki deleted the fix-335 branch September 14, 2024 00:18
@ryanckulp
Copy link

thank you @YusukeIwaki ! this works great. can you PM me (dm@ryanckulp .com) so we can send you a bounty payment? my whole team really appreciates it.

@YusukeIwaki
Copy link
Owner Author

@ryanckulp Thank you for your kind offer. This library is an open-source project, and at this moment, it does not accept commercial funding.
However, any support through GitHub Sponsorship is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox 129 compatability
2 participants