FIX: Issue 414 - failing login for domain change (#788)

* Changed secure cookie and secure token to false * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update docker-compose.yaml Signed-off-by: Ritwik G <[email protected]> * Update backend/sample.env Signed-off-by: Ritwik G <[email protected]> * Update backend/backend/settings/base.py Signed-off-by: Ritwik G <[email protected]> --------- Signed-off-by: Ritwik G <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Zipstack · Nov 5, 2024 · af93d9e · af93d9e
1 parent ce1f565
commit af93d9e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/backend/backend/settings/base.py b/backend/backend/settings/base.py
@@ -83,8 +83,12 @@ def get_required_setting(
 SESSION_EXPIRATION_TIME_IN_SECOND = os.environ.get(
     "SESSION_EXPIRATION_TIME_IN_SECOND", 3600
 )
-SESSION_COOKIE_SECURE = os.environ.get("SESSION_COOKIE_SECURE", True)
-CSRF_COOKIE_SECURE = os.environ.get("CSRF_COOKIE_SECURE", True)
+SESSION_COOKIE_SECURE = CommonUtils.str_to_bool(
+    os.environ.get("SESSION_COOKIE_SECURE", "False")
+)
+CSRF_COOKIE_SECURE = CommonUtils.str_to_bool(
+    os.environ.get("CSRF_COOKIE_SECURE", "False")
+)
 
 PATH_PREFIX = os.environ.get("PATH_PREFIX", "api/v1").strip("/")
 # Resetting the path prefix will require reconfiguring all existing deployed APIs

diff --git a/backend/sample.env b/backend/sample.env
@@ -1,5 +1,9 @@
 DJANGO_SETTINGS_MODULE='backend.settings.dev'
 
+# NOTE: Change below to True if you are running in HTTPS mode.
+SESSION_COOKIE_SECURE=False
+CSRF_COOKIE_SECURE=False
+
 # Default log level
 DEFAULT_LOG_LEVEL="INFO"
 

diff --git a/docker/docker-compose.yaml b/docker/docker-compose.yaml
@@ -149,7 +149,7 @@ services:
       - ENVIRONMENT=development
     labels:
       - traefik.enable=true
-      - traefik.http.routers.frontend.rule=Host(`frontend.unstract.localhost`)
+      - traefik.http.routers.frontend.rule=Host(`frontend.unstract.localhost`)  && !PathPrefix(`/api/v1`, `/deployment`)
 
   platform-service:
     image: unstract/platform-service:${VERSION}