Import enhancements for EnvHelper #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepak-Kesavan
approved these changes
Jan 10, 2025
| @@ -5,9 +5,8 @@ | |||
| from typing import Any, Union | |||
|
|
|||
| from file_management.file_management_helper import FileManagerHelper | |||
| from unstract.sdk.file_storage import FileStorage | |||
| from unstract.sdk.file_storage import EnvHelper, FileStorage | |||
There was a problem hiding this comment.
Does this also need to go under feature flag?
There was a problem hiding this comment.
@gaya3-zipstack Will that be an issue, since this is SDK reference and the class is present in the RC version?
There was a problem hiding this comment.
The reason to keep it under a feature flag is to import the classes only when required. If the class is required only when feature flag is turned on, then it is better to wrap the import also accordingly @harini-venkataraman
| @@ -55,9 +55,8 @@ | |||
| from prompt_studio.prompt_studio_v2.models import ToolStudioPrompt | |||
| from unstract.sdk.constants import LogLevel | |||
| from unstract.sdk.exceptions import IndexingError, SdkError | |||
| from unstract.sdk.file_storage import FileStorage, FileStorageProvider | |||
| from unstract.sdk.file_storage import EnvHelper, FileStorage, FileStorageProvider | |||
There was a problem hiding this comment.
Under feature flag check?
There was a problem hiding this comment.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Import enhancements for EnvHelper
...
Why
Making the import irrespective of file name change.
...
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, these are import enhancements and no logical change
...
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.