Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Removed the logic that conditionally hides the mark_horizontal_lines field #1075

Merged
merged 7 commits into from
Jan 31, 2025
+2 −4
Merged

FIX: Removed the logic that conditionally hides the mark_horizontal_lines field #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f665e5
Remove the logic to hide 'mark_horizontal_lines' field for LLMW V2 ad…
tahierhussain Jan 17, 2025
85e3bf6
Styling improvement for error message for RJSF fields
tahierhussain Jan 17, 2025
a957118
Merge branch 'main' into fix/avoid-conditionally-hiding-the-mark-hori…
tahierhussain Jan 20, 2025
674c041
Merge branch 'main' into fix/avoid-conditionally-hiding-the-mark-hori…
tahierhussain Jan 21, 2025
ab26646
Merge branch 'main' into fix/avoid-conditionally-hiding-the-mark-hori…
tahierhussain Jan 24, 2025
57d8d86
Merge branch 'main' into fix/avoid-conditionally-hiding-the-mark-hori…
athul-rs Jan 31, 2025
a71d277
Merge branch 'main' into fix/avoid-conditionally-hiding-the-mark-hori…
jaseemjaskp Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/layouts/rjsf-form-layout/CustomFieldTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { Typography } from "antd";
import PropTypes from "prop-types";

const CustomFieldTemplate = (props) => {
const { classNames, errors, children, help } = props;
return (
<div className={classNames}>
{children}
{errors}
<Typography.Text type="danger">{errors}</Typography.Text>
{help}
</div>
);
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/layouts/rjsf-form-layout/RjsfFormLayout.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ function RjsfFormLayout({
const uiSchema = useMemo(
() => ({
"ui:classNames": "my-rjsf-form",
mark_horizontal_lines: {
"ui:widget": !formData?.mark_vertical_lines ? "hidden" : undefined,
},
}),
[formData]
);
Expand Down