feat: Reload support for backend, changes to entrypoint script #1100
+185
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekharan-zipstack
requested review from
ritwik-g,
muhammad-ali-e and
hari-kuriakose
ritwik-g
reviewed
Jan 30, 2025
backend/backend/wsgi.py
Outdated
Comment on lines
27
to
30
| start_time = time.time() | ||
| django_app = get_wsgi_application() | ||
| logger.info(f"WSGI application initialized in {(time.time() - start_time):.3f} seconds") | ||
|
|
There was a problem hiding this comment.
May be use time.perf_counter() . This might be more accurate for these sort of use case
ritwik-g
approved these changes
Jan 30, 2025
Signed-off-by: Chandrasekharan M <[email protected]>
| @@ -636,6 +636,7 @@ docker/*.env | |||
| !docker/sample*.env | |||
| docker/public_tools.json | |||
| docker/proxy_overrides.yaml | |||
| docker/compose.override.yaml | |||
There was a problem hiding this comment.
@chandrasekharan-zipstack This might not be needed.
We can check in the actual overrides yaml themselves. It will be activated only when you pass them via the -f flag, hence mentioned.
|
|
hari-kuriakose
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
@chandrasekharan-zipstack LGTM overall.
Extending this we can have docker/compose_overrides/worker.yaml etc and check them in. These will become built-in templates which can be picked by the devs and used as desired. See #1100 (comment) too.
Overall great initiative and really happy to see this. Let's keep improving one small thing at a time. All the best!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
backendentrypoint.shchanges to perform migration and run in dev modeinotifydev dependency to perform better file watching with fewer resourcesWhy
How
pdm run backend --devCan this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Relevant Docs
Dependencies Versions
inotify>=0.2.10Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.