You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initally the credentials for authenticating private images were directly set to the env variable.
This PR changes to a mountable path.
...
Why
This change helps automating On-prem deployents
...
How
Introducing PRIVATE_REGISTRY_CREDENTIAL_PATH for uploading the mount path.
...
Can this PR break any existing features. If yes please list of possible items. If no please exaplin why. (PS: Admins do not merge the PR without this section filled)
This PR will not break existing features.
It introduces an env, where the path of SA Key file is mounted.
If the file is not present, but the env is set - We do not raise exception rather catch and log.
This would prevent the constructor from failing in cases where the private tool is not used.
...
Database Migrations
Not applicable
...
Env Config
PRIVATE_REGISTRY_CREDENTIAL_PATH - Path where the credential file is mounted.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
harini-venkataraman
requested review from
ritwik-g,
nehabagdia and
gaya3-zipstack
What
Initally the credentials for authenticating private images were directly set to the env variable.
This PR changes to a mountable path.
...
Why
This change helps automating On-prem deployents
...
How
Introducing PRIVATE_REGISTRY_CREDENTIAL_PATH for uploading the mount path.
...
Can this PR break any existing features. If yes please list of possible items. If no please exaplin why. (PS: Admins do not merge the PR without this section filled)
This PR will not break existing features.
It introduces an env, where the path of SA Key file is mounted.
If the file is not present, but the env is set - We do not raise exception rather catch and log.
This would prevent the constructor from failing in cases where the private tool is not used.
...
Database Migrations
Not applicable
...
Env Config
PRIVATE_REGISTRY_CREDENTIAL_PATH - Path where the credential file is mounted.
...
Relevant Docs
Not applicable
...
Checklist
I have read and understood the Contribution Guidelines.