[FEAT] Tool Export Validation #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harini-venkataraman
changed the base branch from
main
to
tool-export-validation
harini-venkataraman
changed the base branch from
tool-export-validation
to
main
harini-venkataraman
changed the title
harini-venkataraman
requested review from
tahierhussain,
nehabagdia and
chandrasekharan-zipstack
nehabagdia
approved these changes
Apr 29, 2024
@chandrasekharan-zipstack Yes, this makes sense. But in cases where one or more invalid prompts is stored in a single project, error surfacing each time export is clicked might not be a good user experience. |
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: harini-venkataraman <[email protected]>
chandrasekharan-zipstack
approved these changes
May 2, 2024
backend/prompt_studio/prompt_studio_registry/prompt_studio_registry_helper.py
Show resolved
Hide resolved
backend/prompt_studio/prompt_studio_registry/prompt_studio_registry_helper.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: harini-venkataraman <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR enables support for exporting only valid tools that have prompts and that are executed.
...
Why
This prevents export of dummy tools developed using Prompt Studio.
...
How
Adding validations to see if the Output Manager has a valid field against the prompt.
...
Can this PR break any existing features. If yes please list of possible items. If no please explain why. (PS: Admins do not merge the PR without this section filled)
...
Database Migrations
Not applicable.
...
Env Config
Not applicable.
...
Notes on Testing
...
Screenshots
GT
Checklist
I have read and understood the Contribution Guidelines.