Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Prompt Studio Public Share & Clone #429

Merged
merged 45 commits into from
Jul 15, 2024
Merged

Conversation

harini-venkataraman
Copy link
Contributor

What

Public sharing and clone involves the following changes.

  1. A non interactive Public sharing of a Prompt Studio project to the external world.
  2. Cloning of the Project within the Org
  3. This PR involves all the OSS changes related to the feature.
    ...

Why

Public sharing enables an unauthenticated user get an idea of how prompt studio works and looks like, thereby enabling them take descions.
Clone helps the unauthenticated user make a copy of the same project and sharing within users of same Org.
...

How

  1. Whitelisting a set of Routes and exposing those GET endpoints.
  2. Cloning the hierachy of Django models.
    ...

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

This is a new feature althogether. I cannot cause regressions.
...

Database Migrations

Not applicable
...

Env Config

Not applicable

...

Relevant Docs

https://zipstack.atlassian.net/wiki/spaces/PT/pages/421003286/Prompt+Studio+Public+Sharing+and+Cloning
https://zipstack.atlassian.net/wiki/spaces/PT/pages/430669831/Public+Sharing+-+Prompt+studio+Implementation+design
...

Related Issues or PRs

...

Dependencies Versions

Not applicable

...

Notes on Testing

Loading the appropriate Plugins and starting the server, the features will be visible in the prompt studio page.
...

Screenshots

  1. Clone
    Screenshot from 2024-06-28 16-51-56
  2. Share Link
    Screenshot from 2024-06-28 15-25-11

...

Checklist

I have read and understood the Contribution Guidelines.

@harini-venkataraman harini-venkataraman requested review from tahierhussain, a team and jaseemjaskp and removed request for a team July 1, 2024 00:56
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE changes LGTM

@Deepak-Kesavan Deepak-Kesavan self-requested a review July 9, 2024 08:46
harini-venkataraman and others added 2 commits July 11, 2024 10:35
Co-authored-by: jagadeeswaran-zipstack <[email protected]>
Signed-off-by: harini-venkataraman <[email protected]>
Copy link
Contributor

@Deepak-Kesavan Deepak-Kesavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harini-venkataraman Looks like there are elint issues which is causing frontend build check to fail. Can you look into it and fix it?

@harini-venkataraman
Copy link
Contributor Author

@harini-venkataraman Looks like there are elint issues which is causing frontend build check to fail. Can you look into it and fix it?

@Deepak-Kesavan Can you check now? Fixed and committed the changes.

@Deepak-Kesavan
Copy link
Contributor

Looks like there is one sonar issue. @harini-venkataraman Can you check if that can be solved?

Copy link
Contributor

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

Copy link

@hari-kuriakose hari-kuriakose merged commit 047aed2 into main Jul 15, 2024
5 checks passed
@hari-kuriakose hari-kuriakose deleted the feat/public-share-oss branch July 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants