-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed styling issue in the action items #460
Merged
tahierhussain
merged 1 commit into
main
from
UN-1413-bug-v-0-70-3-staging-regression-unable-to-delete-the-api-deployment
Jul 8, 2024
Merged
Fixed styling issue in the action items #460
tahierhussain
merged 1 commit into
main
from
UN-1413-bug-v-0-70-3-staging-regression-unable-to-delete-the-api-deployment
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
athul-rs
approved these changes
Jul 8, 2024
@tahierhussain It's better to add how a css flex addition solves this issue. |
Deepak-Kesavan
approved these changes
Jul 8, 2024
@athul-rs Thanks for the suggestion. I have updated the PR's description. |
jagadeeswaran-zipstack
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed the issue with selecting items from the dropdown action list.
Why
When the user clicks on the action items, the click event is triggered only when clicking on the text, not the entire row.
How
Created a class called
action-items
and set its display toflex
. This change ensures that the action items occupy the entire width, allowing the click event to trigger for the entire block. Withoutdisplay: flex
, the action item only occupies the width required by the text, leaving the remaining width unused. As a result, the click event doesn't work when clicking outside the text.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, this PR will not break any existing features. It is just a small CSS fix.
Database Migrations
NA
Env Config
NA
Relevant Docs
NA
Related Issues or PRs
https://zipstack.atlassian.net/browse/UN-1413
Dependencies Versions
NA
Notes on Testing
NA
Screenshots
I was able to open the delete modal by clicking outside the "delete" text in the action items.
![Screenshot from 2024-07-08 15-35-40](https://private-user-images.githubusercontent.com/89440263/346519574-5c93e7d3-e61c-46b5-9907-63672eaf7202.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjcwNDEsIm5iZiI6MTczOTU2Njc0MSwicGF0aCI6Ii84OTQ0MDI2My8zNDY1MTk1NzQtNWM5M2U3ZDMtZTYxYy00NmI1LTk5MDctNjM2NzJlYWY3MjAyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIwNTkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3NDA1ZDM0YmJjNGVkZGZiNjdiZDRjOTIwZTUzNjMwNDhjNWNlMmViMjVmODg0ZWVjMDk3ZGFhYjRmNmY4MjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pkiwsuyjXi0oQYWpr9zoS_XQTcab4ELv-aBZ8Z9zu64)
Checklist
I have read and understood the Contribution Guidelines.