Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed styling issue in the action items #460

Conversation

tahierhussain
Copy link
Contributor

@tahierhussain tahierhussain commented Jul 8, 2024

What

Fixed the issue with selecting items from the dropdown action list.

Why

When the user clicks on the action items, the click event is triggered only when clicking on the text, not the entire row.

How

Created a class called action-items and set its display to flex. This change ensures that the action items occupy the entire width, allowing the click event to trigger for the entire block. Without display: flex, the action item only occupies the width required by the text, leaving the remaining width unused. As a result, the click event doesn't work when clicking outside the text.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No, this PR will not break any existing features. It is just a small CSS fix.

Database Migrations

NA

Env Config

NA

Relevant Docs

NA

Related Issues or PRs

https://zipstack.atlassian.net/browse/UN-1413

Dependencies Versions

NA

Notes on Testing

NA

Screenshots

I was able to open the delete modal by clicking outside the "delete" text in the action items.
Screenshot from 2024-07-08 15-35-40

Checklist

I have read and understood the Contribution Guidelines.

@tahierhussain tahierhussain added the bug Something isn't working label Jul 8, 2024
@tahierhussain tahierhussain self-assigned this Jul 8, 2024
@tahierhussain tahierhussain requested review from jaseemjaskp and removed request for a team July 8, 2024 10:12
Copy link

sonarqubecloud bot commented Jul 8, 2024

Copy link
Contributor

github-actions bot commented Jul 8, 2024

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

@athul-rs
Copy link
Contributor

athul-rs commented Jul 8, 2024

@tahierhussain It's better to add how a css flex addition solves this issue.

@tahierhussain
Copy link
Contributor Author

@tahierhussain It's better to add how a css flex addition solves this issue.

@athul-rs Thanks for the suggestion. I have updated the PR's description.

@tahierhussain tahierhussain merged commit 6a3408d into main Jul 8, 2024
5 checks passed
@tahierhussain tahierhussain deleted the UN-1413-bug-v-0-70-3-staging-regression-unable-to-delete-the-api-deployment branch July 8, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants