-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 changes of PromptStudo-Document-Index-Output-Managers #477
v2 changes of PromptStudo-Document-Index-Output-Managers #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muhammad-ali-e Models look good.
We can take care of duplication when we delete v1 eventually. Also, migration files can be generated together later.
backend/prompt_studio/prompt_studio_document_manager_v2/prompt_studio_document_helper.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Added comments based on the context knowledge I have.
…ex-Output-Managers
…ex-Output-Managers
Quality Gate failedFailed conditions |
|
NOTE
What
Why
How
get_organization
method to utilize the user context.apps.py
.models
with updated table names.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.