-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Test connector error handling improvements #496
Conversation
unstract/connectors/src/unstract/connectors/filesystems/google_drive/google_drive.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a minor comment.
unstract/connectors/src/unstract/connectors/filesystems/minio/exceptions.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Kept one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would left @johnyrahul 's comment to resolve
|
|
What
TODO
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Dependencies Versions
dropboxdrivefs
to 1.4.1 -> helps address an issue with listing filesNotes on Testing
Screenshots
S3 related
![image](https://private-user-images.githubusercontent.com/117059509/349439504-e5cba44b-4038-4560-ad68-510a341f5f95.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODIxNTYsIm5iZiI6MTczODk4MTg1NiwicGF0aCI6Ii8xMTcwNTk1MDkvMzQ5NDM5NTA0LWU1Y2JhNDRiLTQwMzgtNDU2MC1hZDY4LTUxMGEzNDFmNWY5NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwMjMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wMTE4OGYwNGRhZGIwYWRkYzNiMWUzMTc1NTlkMDJjMDhjNmRhMjg0NzAwNTkxYjU4NDQxNDI1MWZkZTJkOWFhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.oqNsZt3eIifbiOx0mAs3D9QYdmM95_blTuiiydYelGs)
![image](https://private-user-images.githubusercontent.com/117059509/349439922-ff3e9824-fb37-4497-8378-85b77f7102a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODIxNTYsIm5iZiI6MTczODk4MTg1NiwicGF0aCI6Ii8xMTcwNTk1MDkvMzQ5NDM5OTIyLWZmM2U5ODI0LWZiMzctNDQ5Ny04Mzc4LTg1Yjc3ZjcxMDJhNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwMjMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05YjRiODE2NzAyZmFlOTBiYTYzZGIwN2IyYjFmNjgxN2Q4MzY3OGRmMjczYWU5ZWM0MzUyMWNhOTUxYjNiMzM5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.8-iPb691PNZzsvDgAP17HN0RD2Xq0H1tcEh86rMxP98)
![image](https://private-user-images.githubusercontent.com/117059509/349440088-eb255e29-e546-40e3-a86d-55f3949b2a93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODIxNTYsIm5iZiI6MTczODk4MTg1NiwicGF0aCI6Ii8xMTcwNTk1MDkvMzQ5NDQwMDg4LWViMjU1ZTI5LWU1NDYtNDBlMy1hODZkLTU1ZjM5NDliMmE5My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwMjMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNWI1ZDIwYjQyNmVkOGJkNGYzN2NjNzBmZmI0MDdlYzMxNjc0NzQyMjdjYmRhYjMzMTZjZTdkZTc1YmU4Y2ExJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ifzbvuE6Dt4l8OfQgc7vIUJGrjcKrao6hjMQLJcUJvM)
![image](https://private-user-images.githubusercontent.com/117059509/349440315-48f3c43f-2012-4b81-a231-23b90f1d95a8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODIxNTYsIm5iZiI6MTczODk4MTg1NiwicGF0aCI6Ii8xMTcwNTk1MDkvMzQ5NDQwMzE1LTQ4ZjNjNDNmLTIwMTItNGI4MS1hMjMxLTIzYjkwZjFkOTVhOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwMjMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOTE4Y2YzOWRiNThjNzg4NWY2ZDhmYzhhZmI0OTkxNDk4MTY4OGNjYWJkMmM0NjZmNTJhYmQyNzljNDdkZDhiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.LF6Mdznc0cKdvp-DM27jsuRrx-GY2JELnPYPTDvRFnI)
Few errors which are not explicitly converted show up like below
Dropbox related
![image](https://private-user-images.githubusercontent.com/117059509/349438812-15946606-fe07-46d4-9d7b-655bd1ec3256.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODIxNTYsIm5iZiI6MTczODk4MTg1NiwicGF0aCI6Ii8xMTcwNTk1MDkvMzQ5NDM4ODEyLTE1OTQ2NjA2LWZlMDctNDZkNC05ZDdiLTY1NWJkMWVjMzI1Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwMjMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wODc3MzY3OTljYjA5MzI3YjdmNDJkNDdkZjZlOTZmNTYzMGU4NzljZWQ3MWU3Nzc3MDk4OTQ5NzEwZTRmMWY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0iV0N7uEUCvpNUspytTX_quvs0QwiLUh0HunMchMjIk)
![image](https://private-user-images.githubusercontent.com/117059509/349438862-ab1e3e98-95e3-44b9-a8b6-175dd77d9ec4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODIxNTYsIm5iZiI6MTczODk4MTg1NiwicGF0aCI6Ii8xMTcwNTk1MDkvMzQ5NDM4ODYyLWFiMWUzZTk4LTk1ZTMtNDRiOS1hOGI2LTE3NWRkNzdkOWVjNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwMjMwNTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zZWY3ZWRjOWIyOGFjZTdjYmNkYmIxMzNkZDQzN2U2ODFmNTM3ZDMzN2ZiZWU4OWM1NDIzOWFmNTg1ZDIyM2E5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.vaFDHtsWzA6EoGBBQe2jGATuc8qFG1OLFGkO-ewfl4A)
Checklist
I have read and understood the Contribution Guidelines.