changes in worker and tools related to sdk filestorage #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-ali-e
requested review from
harini-venkataraman,
chandrasekharan-zipstack,
vishnuszipstack,
hari-kuriakose,
gaya3-zipstack and
a team
chandrasekharan-zipstack
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
LGTM - @muhammad-ali-e don't you need to update the tool's requirements.txt to use the intended SDK version?
@chandrasekharan-zipstack It will be updated once we transition out of the beta phase |
gaya3-zipstack
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Changes look fine. Except for tool version changes suggested by @chandrasekharan-zipstack
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: ali <[email protected]>
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: ali <[email protected]>
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: ali <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remote FileStorage.Why
FileStoragefeature.How
hasattr(self, "workflow_filestorage")for backward compatibility, as the upcoming SDK version will introduce theworkflow_filestorageproperty in theBaseToolclass.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.