Constify read-only Selection argument for FindLink and FindExact #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiolo
force-pushed
the
constify-selection-in-findlink-findexact
branch
from
8a67bee to
8f02ced
Compare
tobiolo
changed the title
|
const changes are so simple and harmless, you can probably combine some in one pr. Or rather, just push it yourself, I can't imagine |
This commit constifies the read-only argument passed by reference for
`{Cell,Grid}::{FindLink,FindExact}(...)`.
tobiolo
force-pushed
the
constify-selection-in-findlink-findexact
branch
from
8f02ced to
ed59fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit constifies the Selection argument passed by reference for
{Cell,Grid}::{FindLink,FindExact}(...)as they are only read.