Use const char* instead of const w_char_t* #799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiolo
force-pushed
the
const-char
branch
2 times, most recently
from
c4c2d32 to
9e98245
Compare
|
We could also instead use |
|
I think as long as we stick to UTF-8 encoding this should work? |
|
See my comments on your other similar PR. While this seems nice (I much prefer UTF-8 everywhere), I don't understand why this is suddenly possible/necessary, and how it affects builds against various versions of wxWidgets. |
|
You are absolutely right: I asked upstream. |
|
This will be fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: wxWidgets macro for localization only uses const char, so let's clean up the whole code. Only use w_char_t where it is absolutely necessary (Windows API).