Avoid double ownership #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiolo
force-pushed
the
avoid-double-ownership
branch
from
42394ce to
7f31052
Compare
tobiolo
added a commit
to tobiolo/treesheets
that referenced
this pull request
Jan 16, 2025
This reverts commit 89b40de.
tobiolo
added a commit
that referenced
this pull request
Jan 16, 2025
* Revert "Avoid double ownership (#800)" This reverts commit 89b40de. * Revert "Fix bad unique_ptr usage" This reverts commit 2086ce8. * Revert "Use correct method to delete resource (#783)" This reverts commit 81e74a0. * Revert "Use unique_ptr for Grid in Cell (#782)" This reverts commit 9fe088a. * Revert "Make rootgrid an unique_ptr (#776)" This reverts commit 15d5f58. * Revert "Use vector instead of raw pointer arrays (#785)" This reverts commit 9dfc4fb. * Revert "Use unique_ptr for Document in TSCanvas (#780)" This reverts commit e3d4602.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @aardappel for your explanation and your fix! This seems to be a very subtle issue. I tried to understand the mechanics here and suggest following fix to avoid the double ownership of
candrootgrid.get().