Support Sidx and Styp #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ReferenceID uint32 `mp4:"size=32"` | ||
| TimeScale uint32 `mp4:"size=32"` | ||
| EarliestPresentationTime uint32 `mp4:"size=32"` | ||
| FirstOffset uint32 `mp4:"size=32"` |
There was a problem hiding this comment.
If Sidx.Version don't equal to 0, Sidx.EarliestPresentationTime and Sidx.FirstOffset have 64 bits.
So could you use ver option as follows?
EarliestPresentationTimeV0 uint32 `mp4:"size=32,ver=0"`
FirstOffsetV0 uint32 `mp4:"size=32,ver=0"`
EarliestPresentationTimeV1 uint64 `mp4:"size=64,nver=0"`
FirstOffsetV1 uint64 `mp4:"size=64,nver=0"`
There was a problem hiding this comment.
Sorry, I was mistaken.
This PR accept only version 0 at line 8 (https://github.com/abema/go-mp4/pull/18/files#diff-6322880a133c5e374279625376187a10R8) , and is correct.
There was a problem hiding this comment.
FYI, If supporting both of version 0 and version 1, you can write as follows:
func init() {
AddBoxDef(&Sidx{}, 0, 1)
}
:
:
EarliestPresentationTimeV0 uint32 `mp4:"size=32,ver=0"`
FirstOffsetV0 uint32 `mp4:"size=32,ver=0"`
EarliestPresentationTimeV1 uint64 `mp4:"size=64,nver=0"`
FirstOffsetV1 uint64 `mp4:"size=64,nver=0"`
| References []struct { | ||
| TypeSize uint32 `mp4:"size=32"` | ||
| SubSegmentDuration uint32 `mp4:"size=32"` | ||
| SapStartsTypeDeltaTime uint32 `mp4:"size=32"` |
There was a problem hiding this comment.
Reference entity has defined in spec as follows:
bit (1) reference_type;
unsigned int(31) referenced_size;
unsigned int(32) subsegment_duration;
bit(1) starts_with_SAP;
unsigned int(3) SAP_type;
unsigned int(28) SAP_delta_time;
So, I think that this struct may be written like following code.
ReferencedType bool `mp4:"size=1"`
ReferencedSize uint32 `mp4:"size=31"`
SubsegmentDuration uint32 `mp4:"size=32"`
StartsWithSAP bool `mp4:"size=1"`
SAPType uint8 `mp4:"size=3"`
SapStartsTypeDeltaTime uint32 `mp4:"size=28"`
Do you refer to older spec?
|
This PR is related to #13 |
|
I will take on this task in #35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunfish-shogi
Support box types styp and sidx used in MPEG-DASH