Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic): fallback to default create method if value is not an URI #1595

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(generic): fallback to default create method if value is not an URI #1595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apis_core/generic/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
from django.contrib import messages
from django.contrib.auth.mixins import PermissionRequiredMixin
from django.contrib.contenttypes.models import ContentType
from django.core.exceptions import ImproperlyConfigured
from django.core.exceptions import ImproperlyConfigured, ValidationError
from django.core.validators import URLValidator
from django.forms import modelform_factory
from django.forms.utils import pretty_name
from django.shortcuts import get_object_or_404, redirect
Expand Down Expand Up @@ -345,7 +346,11 @@ def get_results(self, context):
return results

def create_object(self, value):
return create_object_from_uri(value, self.queryset.model, raise_on_fail=True)
try:
URLValidator(value)
return create_object_from_uri(value, self.queryset.model, raise_on_fail=True)
except ValidationError:
return super().create_object(value)

def post(self, request, *args, **kwargs):
try:
Expand Down
Loading