feat: add opengraph images with dynamic title #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should now be working - we generate opengraph images at build time for events, news, and projects. note that this will add ~150 MB to the docker image. |
|
examples how this currently looks like:
@PixlTracer opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a public endpoint to dynamically generate opengraph images.images should probably be statically generated at build time and served with cache headers - but this would bloat the docker image even further.one thing to think about is that any image we want to display on the og image probably needs to live in the public folder (i.e. docker image) - unless we can generate all of them at build time.this pr generates static opengraph images for events, news, and projects at build time.
TODO: