Core - Fix load/save of deleted entities such as bushes and trees #153
Conversation
EntityIDs are constructed from Low and high 32-bit IDs, the original code here didn't account for entities that have a high ID of zero, and values that were less then 8 characters long. This new implementation removes the float math and uses bitwise operations to correctly convert to the expected array format in the correct byte order with no length limitations for the input.
Map entities such as trees and bushes do not have a high ID. This results in the game engine returning `0x0x` prefixes when ToString is called. ToInt and FromString have also been updated to use a high ID of 0 when the array only contains a single element.
There was a problem hiding this comment.
Thanks for the investigation and fix. Especially the 0x0x prefix makes me suspect that there's a bug in the pointer.ToString method on Linux. I'll probably open a ticket for it. For now we gonna have to handle it anyway. Btw. don't forget to add yourself as contributor to the AUTHORS file.
Kexanone
changed the title
Since implementing these fixes I have not seen this again, I am pretty sure it was happening because the old HexStringToInt was returning an empty array, which was then treated as EntitiID.INVALID, resulting in the |
|
True, but I would argue that |
|
Perhaps in |
|
Or we write it as |
|
I think we should do both actually, people upgrading with existing saves will have files full of |
|
Also handle the unprefixed version |
|
Done, and included handling of invalid IDs when loading the save. Note I have not tested this latest patch, I am away from my dev system atm. |
|
Just FYI, I have now tested this and everything is working as expected. |
This resolves #152, aka the "Wrong parameter value" error mentioned in #35. Patches contain comments to explain the exact cause and resolution of the issue.