Medical - Improve Epi status message in the event of critical injury #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If medkit is still usable to heal hitzones, the message will still display 'too injured'. If a patient is critically injured and fully healed in the field, the message wil display 'critically injured'
Kexanone
changed the title
|
Corrected logic with requested addition and updated localization messages |
Kexanone
requested changes
Jul 29, 2024
addons/medical/scripts/Game/ACE_Medical/Components/Damage/SCR_CharacterDamageManagerComponent.c
Outdated
Show resolved
Hide resolved
Kexanone
requested changes
Aug 5, 2024
addons/medical/scripts/Game/ACE_Medical/Components/Damage/SCR_CharacterDamageManagerComponent.c
Outdated
Show resolved
Hide resolved
Kexanone
requested changes
Aug 6, 2024
addons/medical/scripts/Game/ACE_Medical/Components/Damage/SCR_CharacterDamageManagerComponent.c
Outdated
Show resolved
Hide resolved
addons/medical/scripts/Game/ACE_Medical/Components/Gadgets/SCR_ConsumableEffectBase.c
Outdated
Show resolved
Hide resolved
Kexanone
requested changes
Aug 6, 2024
addons/medical/scripts/Game/ACE_Medical/Components/Gadgets/ACE_Medical_ConsumableEpinephrine.c
Outdated
Show resolved
Hide resolved
Also updated docstring
…o clarify the issue from previous message
…ead of accepting any float
Kexanone
requested changes
Aug 6, 2024
addons/medical/scripts/Game/ACE_Medical/Components/Damage/SCR_CharacterDamageManagerComponent.c
Outdated
Show resolved
Hide resolved
addons/medical/scripts/Game/ACE_Medical/Components/Gadgets/ACE_Medical_ConsumableEpinephrine.c
Outdated
Show resolved
Hide resolved
addons/medical/scripts/Game/ACE_Medical/Components/Gadgets/ACE_Medical_ConsumableEpinephrine.c
Outdated
Show resolved
Hide resolved
veteran29
requested changes
Dec 11, 2024
| @@ -1,6 +1,7 @@ | |||
| ACE_SettingsConfig { | |||
| m_aInitialModSettings { | |||
| ACE_Medical_Settings "{60FD72EFA3DB8236}" { | |||
| m_bSecondChanceOnHeadEnabled 1 | |||
There was a problem hiding this comment.
I don't think we want to edit default settings? @Kexanone ?
There was a problem hiding this comment.
Yeah, that should remain disabled.
| @@ -14,6 +14,7 @@ modded class SCR_CharacterDamageManagerComponent : SCR_DamageManagerComponent | |||
| protected ACE_Medical_PainHitZone m_pACE_Medical_PainHitZone; | |||
| protected float m_fACE_Medical_ModeratePainThreshold; | |||
| protected float m_fACE_Medical_SeriousPainThreshold; | |||
| protected float m_fACE_Medical_MedicalKitMaxHeal; | |||
There was a problem hiding this comment.
Settings needs to be replicated, move down to other Rpl props. Also needs a default value in case the settings are not there.
Suggested change
| protected float m_fACE_Medical_MedicalKitMaxHeal; | |
| [RplProp()] | |
| protected float m_fACE_Medical_MedicalKitMaxHeal; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epi Status Messages: