-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support timeout-minutes in composite-actions #1979
Comments
👋 +1 |
+1000 behalf of all of our Developers and Automation Engineers who need this badly ! |
+1111 |
+2222 |
Just recently came across this limitation. I hope it will be implemented swiftly. |
+1 |
It's weird not to have this option. |
+1 |
please stop commenting +1, many of us are subscribed to receive updates on this issue
|
Reverts #8287 Apparently composite actions do not support timeout. See actions/runner#1979.
actions/runner#1979 Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
not stale, still wanted, hire more people |
Dear GitHub, kind ask to introduce this option into composite actions |
There may be times where the trunk action is unresponsive and is hung in CI. To understand whether this is a linter or trunk cli issue, we'll need logs to confirm. This PR adds the following optional inputs `timeout-seconds` and `cat-trunk-debug-logs` which will wrap the trunk check action with the unix `timeout` command should the user supply an argument for `timeout-seconds` Should the user specify `cat-trunk-debug-logs: true`, the trunk action will also cat out cli & daemon logs from `.trunk/logs/` Unfortunately, `timeout-minutes` doesn't work in `composite-actions` see actions/runner#1979 and https://github.com/orgs/community/discussions/50481 **Test Plan**: <details> <summary>End to End test to ensure timeout + logs work</summary> <img width="1873" alt="image" src="https://github.com/trunk-io/trunk-action/assets/31294356/27ca9a1b-fe54-4e73-928e-63625d1f934e"> </details> <details> <summary>End to End test to ensure timeout works </summary> <img width="1878" alt="image" src="https://github.com/trunk-io/trunk-action/assets/31294356/8fb7351a-11c0-4e83-9490-864c6ecdafc0"> </details> - [ ] Add Regression test (not entirely sure I can run this workflow) May need some help here!
Describe the enhancement
We would like to see
timeout-minutes
supported on steps in composite actionsCode Snippet
If applicable, add a code snippet.
Additional information
Occasionally actions like actions/cache bug out (see actions/cache#810 etc) and run for the default timeout time (6 hours) which causes unnecessary costs and extra work as CI will be left running and needs to be aborted and re-run.
With the possibility to set timeout-minutes on steps in composite actions this damage could be limited and have actions finish in a timely manner even if the cache action fails.
I see from previous ADRs 0549 and 1144 that timeout-minutes are to be considered in the future and last mention it was waited with due to little buzz about this feature missing, so heres some buzz 🐝 🙂
NOTE: if the feature request has been agreed upon then the assignee will create an ADR. See docs/adrs/README.md
The text was updated successfully, but these errors were encountered: