ci: timeout-minutes has a known issue with composite

use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
ideepika · Feb 20, 2023 · 25c0132 · 25c0132
1 parent 7623c0e
commit 25c0132
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -66,6 +66,7 @@ jobs:
         run: tests/scripts/validate_modified_files.sh gen-rbac
 
       - name: consider debugging
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -99,6 +100,7 @@ jobs:
 
       - name: consider debugging
         if: failure()
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
diff --git a/.github/workflows/canary-integration-test.yml b/.github/workflows/canary-integration-test.yml
@@ -204,6 +204,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -257,6 +258,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -304,6 +306,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -357,6 +360,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -455,6 +459,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -528,6 +533,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -577,6 +583,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -629,6 +636,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -698,6 +706,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -749,6 +758,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -801,6 +811,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -881,6 +892,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -943,6 +955,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -997,6 +1010,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -1247,6 +1261,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -1275,6 +1290,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -1306,6 +1322,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -1387,6 +1404,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
@@ -1439,6 +1457,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
diff --git a/.github/workflows/integration-test-helm-suite.yaml b/.github/workflows/integration-test-helm-suite.yaml
@@ -63,6 +63,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
diff --git a/.github/workflows/integration-test-mgr-suite.yaml b/.github/workflows/integration-test-mgr-suite.yaml
@@ -57,6 +57,7 @@ jobs:
 
       - name: consider debugging
         if: failure() && github.event_name == 'pull_request'
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
diff --git a/.github/workflows/push-build.yaml b/.github/workflows/push-build.yaml
@@ -78,6 +78,7 @@ jobs:
 
       - name: consider debugging
         if: failure()
+        timeout-minutes: 60
         uses: ./.github/workflows/tmate_debug
         with:
           use-tmate: ${{ secrets.USE_TMATE }}
diff --git a/.github/workflows/tmate_debug/action.yml b/.github/workflows/tmate_debug/action.yml
@@ -3,12 +3,7 @@ description: "Setup tmate session if the test fails"
 inputs:
   use-tmate:
     description: "boolean for enabling TMATE"
-    required: false
-  timeout-minutes:
-    description: "timeout tmate debug session"
-    required: false
-    default: '60'
-# ...name, description and inputs as above
+    required: true
 runs:
   using: "composite"
   steps:
@@ -20,9 +15,7 @@ runs:
         if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ inputs.use-tmate }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
           echo USE_TMATE=1 >> $GITHUB_ENV
         fi
-        echo "${{ inputs.timeout-minutes }}"
 
     - name: set up tmate session for debugging
       if: failure() && env.USE_TMATE
       uses: mxschmitt/action-tmate@v3
-      timeout-minutes: "${{ inputs.timeout-minutes }}"