Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs version with respecting the runs.using #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kachick
Copy link

@kachick kachick commented Dec 19, 2024

Description

Now using different nodejs version with action.yml.
Is this an intentional change?

runs:
using: node20

As far as I know, GitHub Action JavaScript runner does not support nodejs 22 engine yet.

ref: #923, #940


What I did

Revert following commits

Prevent similar troubles with following changes

  • Add ignore entry for dependabot config
  • Restrict engines.node in package.json

Revert following commits

- 2e3c15b
- Part of 7c33447

Prevent similar troubles with following changes

- Add ignore entry for dependabot config
- Restrict engines.node in package.json
@kachick kachick requested a review from a team as a code owner December 19, 2024 18:03
@Osama2535
Copy link

وصف

لقد استخدمت الآن إصدارًا مختلفًا من Nodejs باستخدام action.yml. هل هذا تغييرود؟

runs:
using: node20

بقدر ماتعلم، فإن تشغيل برنامج JavaScript الخاص بـ GitHub Action لا يدعم محرك Nodejs 22 حتى الآن.

المرجع: #923 ، #940

ماذا فعلت

الفن عن الالتزامات التالية

تجنب شراء نفس باتباع التغييرات التالية

  • إضافة تجاهل تجاهل لتكوين التابع
  • تمامًا مثل Engines.node في package.json

Osama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants