RP2040 WDT=8.3secs - enable after wifi connect #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
WDT-RP2040-enable-after-wifi-connect
branch
2 times, most recently
from
b093b99 to
39231b3
Compare
tyeth
force-pushed
the
WDT-RP2040-enable-after-wifi-connect
branch
from
39231b3 to
2475f33
Compare
brentru
requested changes
Dec 19, 2024
src/Wippersnapper.cpp
Outdated
| @@ -2748,8 +2748,10 @@ void Wippersnapper::connect() { | |||
| // Dump device info to the serial monitor | |||
| printDeviceInfo(); | |||
|
|
|||
| // enable global WDT | |||
| // enable global WDT | |||
| #ifndef ARDUINO_ARCH_RP2040 | |||
| WS.enableWDT(WS_WDT_TIMEOUT); | |||
There was a problem hiding this comment.
Consider moving this guard into the enableWDT() call, so we aren't ifndef''ing each time we call enableWDT()`
|
@brentru this one too please (switched enableWDT to after wifi connect) |
brentru
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from wifi sorting pr, needed ideally (works without but wifi multi times out at 8seconds) before release of firmware version for #664