Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sen6x, derived from sen5x driver #675

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MartinEbnerSensirion
Copy link

No description provided.

@MartinEbnerSensirion MartinEbnerSensirion changed the title derived from sen5x driver add sen6x, derived from sen5x driver Dec 22, 2024
@tyeth tyeth requested review from brentru and tyeth December 22, 2024 23:55
@tyeth
Copy link
Contributor

tyeth commented Dec 22, 2024

I'm technically off and Brents around next week so added him too. Thanks for the rapid driver PR. The component should appear in the new components dialog (listed as in-development with associated warnings) if you Refresh any open IO page.

@MartinEbnerSensirion
Copy link
Author

not entirely sure why some checks fail, code compiles for my raspi pico w and appears to work also via adafruit io... it's getting late here, so i'll have another look tomorrow.

@tyeth
Copy link
Contributor

tyeth commented Dec 23, 2024

This appears to be the error (include header for sen66 not found)

/home/runner/Arduino/libraries/Adafruit_Wippersnapper_Arduino/src/components/i2c/drivers/WipperSnapper_I2C_Driver_SEN6X.h:21:10: fatal error: SensirionI2CSen66.h: No such file or directory
21 | #include <SensirionI2CSen66.h>

https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/12458719555/job/34774597744#step:16:202

The example row in log expands and then keep pressing end/page-down while it loads examples ardu build log

@brentru
Copy link
Member

brentru commented Dec 23, 2024

@tyeth Buids are failing for Arduino SAMD21 boards due to being out of flash space. I am in favor of temporarily removing these boards from our build pipeline until we finalize WipperSnapper with the new API, v2. The new API's goal is to reduce the size of this firmware, it might fit! So, I'd like to see if the final version of the API will reduce code space enough to support SAMD21. If it doesn't fit, we'll drop this platform in favor of SAMD51 which has plenty of room.

@MartinEbnerSensirion Would you mind if we hold this PR until after the holidays (Xmas + New Years) when Tyeth and I are both back to discuss it together? The contents of it have been reviewed and approved by both of us but we may have to remove a platform.

@tyeth
Copy link
Contributor

tyeth commented Dec 23, 2024

Thanks Brent, that sounds good, people can use the CI assets for now anyway

@ladyada
Copy link
Member

ladyada commented Dec 23, 2024

coooool :)

@MartinEbnerSensirion
Copy link
Author

sure, happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants