Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature_sensor device revision #26

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Oct 27, 2024

Fix temperature_sensor device revision to match 1.3 specs

Fix temperature_sensor device revision to match 1.3 specs
@lboue lboue marked this pull request as ready for review October 27, 2024 12:05
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is another file that needs copyright info.

@lboue
Copy link
Contributor Author

lboue commented Nov 26, 2024

Looks like there is another file that needs copyright info.

Fixed but now there is another error

Extension error (autoapi.extension):
Handler <function run_autoapi at 0x7f0d1ee68680> for event 'builder-inited' threw an exception (exception: Relative import with too many levels (1) for module 'temperature_sensor')

@tannewt
Copy link
Member

tannewt commented Nov 26, 2024

I think the sensor directory needs an empty __init__.py to make the folder a package wrt to imports.

@tannewt
Copy link
Member

tannewt commented Nov 26, 2024

The measurement folder needs it too.

@lboue
Copy link
Contributor Author

lboue commented Nov 26, 2024

The measurement folder needs it too.

Thanks for the tip. Fixed.

@lboue lboue requested a review from tannewt November 26, 2024 20:20
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 14140f7 into adafruit:main Nov 27, 2024
1 check passed
@lboue lboue deleted the patch-5 branch November 27, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants