Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCP2221A #137

Closed
wants to merge 0 commits into from
Closed

Add MCP2221A #137

wants to merge 0 commits into from

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 29, 2024

Adds board definition for MCP2221A

@lorennorman Please note L9,

"installMethod": "python",

This is a new installMethod. For now, all it means is that the board won't appear on the New Board workflow and does not include assets.

Resolves: #136

@brentru brentru requested a review from lorennorman February 29, 2024 16:55
@brentru
Copy link
Member Author

brentru commented Feb 29, 2024

@lorennorman The CI is erroring that the SCL/SDA should be an int, which is correct in V1 of the API:
https://github.com/adafruit/Wippersnapper_Protobuf/blob/master/proto/wippersnapper/i2c/v1/i2c.proto#L27

However, CircuitPython uses strings for naming rather than ints. Within I2CBusInitRequest.

For API V2, which'll be utilized by the MCP2221A, do you see any issues on your end with changing i2c_pin_scl and i2c_pin_sda from int32 type to string types?

Copy link
Contributor

@lorennorman lorennorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

If you want to loosen the JSON schema type check to also allow strings you can change boards/schema.json lines 151 and 152 to take an array of possible types, like:

              "SDA": { "type": [ "number", "string" ]},
              "SCL": { "type": [ "number", "string" ]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Adafruit MCP2221A Breakout
2 participants