Replaced hardcoded iconDimensions w/ manifest extraction in `sync.f…

…ade()`, eliminated `iconPaths` init for compactness ↞ [auto-sync from https://github.com/adamlui/ai-web-extensions]
adamlui · Jan 5, 2025 · eec9846 · eec9846
1 parent f122419
commit eec9846
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/chromium/extension/popup/controller.js b/chromium/extension/popup/controller.js
@@ -25,10 +25,10 @@
         fade() {
 
             // Update toolbar icon
-            const iconDimensions = [16, 32, 48, 64, 128], iconPaths = {}
-            iconDimensions.forEach(dimension => iconPaths[dimension] = `../icons/${
-                config.extensionDisabled ? 'faded/' : '' }icon${dimension}.png` )
-            chrome.action.setIcon({ path: iconPaths })
+            chrome.action.setIcon({ path: Object.fromEntries(
+                Object.keys(chrome.runtime.getManifest().icons).map(dimension =>
+                    [dimension, `../icons/${config.extensionDisabled ? 'faded/' : ''}icon${dimension}.png`]
+            ))})
 
             // Update menu contents
             document.querySelectorAll('div.logo, div.menu-title, div.menu')

diff --git a/firefox/extension/popup/controller.js b/firefox/extension/popup/controller.js
@@ -25,10 +25,10 @@
         fade() {
 
             // Update toolbar icon
-            const iconDimensions = [16, 32, 48, 64, 128], iconPaths = {}
-            iconDimensions.forEach(dimension => iconPaths[dimension] = `../icons/${
-                config.extensionDisabled ? 'faded/' : '' }icon${dimension}.png` )
-            chrome.action.setIcon({ path: iconPaths })
+            chrome.action.setIcon({ path: Object.fromEntries(
+                Object.keys(chrome.runtime.getManifest().icons).map(dimension =>
+                    [dimension, `../icons/${config.extensionDisabled ? 'faded/' : ''}icon${dimension}.png`]
+            ))})
 
             // Update menu contents
             document.querySelectorAll('div.logo, div.menu-title, div.menu')