Status of keyboard shortcuts

[ElijahLynn]

I see in the code there is preliminary support for keyboard shortcuts and if I manually add a 'shortcuts' key to local storage they do work! My question is what needs to be done to get this finished. I am not entirely sure how to do this but with some simple guidance I may be able to submit a PR for this.

At any rate, would love to see this implemented!

[adampash]

Hey Elijah,

There were a couple of issues with the shortcuts that made me remove them
from the extension.

1. They just didn't work that well. I think the implementation would need
   to be improved/be more reliable.
2. I shortsightedly coded them for use on OS X, not thinking about the fact
   that the defaults would conflict w/existing shortcuts on Windows.

I think the two things that would need to be done in order to put shortcuts
back are:

1. An improved way of getting them to work more consistently. Some
   extensions shortcuts seem to work really well — e.g., I've noticed Pocket's
   shortcut seems really responsive, and to work v. consistently. When I have
   time, I've told myself I need to look into how they're doing it.
2. Shortcuts have sensible defaults and/or should be customizable.

If those two problems were taken care of, I'd happily put this back into
the extension — and I'd be thrilled to accept a pull request! ;)

On Wed, Sep 11, 2013 at 2:40 PM, Elijah Lynn [email protected]:

I see in the code there is preliminary support for keyboard shortcuts and
if I manually add a 'shortcuts' key to local storage they do work! My
question is what needs to be done to get this finished. I am not entirely
sure how to do this but with some simple guidance I may be able to submit a
PR for this.

At any rate, would love to see this implemented!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.

[ElijahLynn]

Great summary Adam! This may be something I can take on, I will post back here if/when I start work on it so if anyone else sees this in the meantime and I haven't posted yet feel free to get started on it!

[ElijahLynn]

Fyi Adam, currently the Chrome Store extension states that it has shortcuts:

Music Plus adds controls, notifications, Last.fm support, downloading, global keyboard shortcuts, and lyrics to Google Play Music.

[ElijahLynn]

Gonna leave this here for whomever ends up working on this. Thanks @ericduran.

http://smus.com/chrome-media-keys/

[mammuth]

Hi,
is anyone currently working on the shortcuts? This is a must-have feature in my eyes.
Maybe it is even possible to use the built-in media keys?

Greetings,
Max

[dkrisd]

Shortcuts don't work on Ubuntu 12.04. Chrome Version 36.0.1985.125