Skip to content

Commit

Permalink
Merge pull request #35 from adevinta/lava-readme
Browse files Browse the repository at this point in the history
README.md, CONTRIBUTING.md: add README and contribution guidelines
  • Loading branch information
jroimartin authored Nov 29, 2023
2 parents 8c0c5fd + b25d962 commit ec9ba34
Show file tree
Hide file tree
Showing 2 changed files with 119 additions and 0 deletions.
74 changes: 74 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# Contributing

**This project is in an early stage, we are not accepting external
contributions yet.**

## Workflow

The recommended workflow is feature branching.
That means that new features are developed in branches that are merged
to main once they are tested, reviewed and considered stable.

Small, short-lived and self-contained feature branches along with
small pull requests are recommended.
Feature flags are helpful to avoid having very long lived branches
that can be sometimes hard to merge, depending on how quickly the main
branch is updated.

The main branch of this repository is protected.
No one is allowed to push directly to main.

## Commit messages

Commit messages in this project follow a specific set of conventions,
which we discuss in this section.

```
Header line: explain the commit in one line (use the imperative)
Body of commit message is a few lines of text, explaining things
in more detail, possibly giving some background about the issue
being fixed, etc.
The body of the commit message can be several paragraphs, and
please do proper word-wrap and keep columns shorter than about
74 characters or so. That way "git log" will show things
nicely even when it's indented.
Make sure you explain your solution and why you're doing what you're
doing, as opposed to describing what you're doing. Reviewers and your
future self can read the patch, but might not understand why a
particular solution was implemented.
```

The header line of the commit must be prefixed by the primary affected
component followed by colon.

The body of the commit can be omitted if the header line describes the
change well enough and the pull request message contains the missing
details.

## Pull requests

Similarly to what happens with commit messages, pull requests follow a
specific set of conventions.

The title must explain the pull request in one line (use the
imperative) and must be prefixed by the primary affected component
followed by colon.

The body of the pull request is a few lines of text, explaining things
in more detail, possibly giving some background about the issue being
fixed, etc.

Make sure you explain your solution and why you're doing what you're
doing, as opposed to describing what you're doing.
Reviewers and your future self can read the patch, but might not
understand why a particular solution was implemented.

Pull requests must be in a "mergeable" state, pass all the automatic
checks and receive at least +1 from the reviewers before being merged.

When merging pull requests, using merge commits is mandatory.
That means that the commit history of the pull request must be
meaningful and clean.
45 changes: 45 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1 +1,46 @@
# Lava

Lava is an open source vulnerability scanner that makes it easy to run
security checks in your local and CI/CD environments.

Lava is part of the [Vulcan ecosystem][vulcan-docs] and it is built on
top of the same components that power Vulcan.
Thus, Lava continuously benefits from Vulcan improvements.
In fact, Lava is compatible with the [vulcan-checks][vulcan-checks]
catalog shipped with Vulcan.

## Install

### Install From Source

Install the Lava command with `go install`.

```
go install github.com/adevinta/lava/cmd/lava@latest
```

### GitHub Actions

Lava is also available as an action that can be used from GitHub
Actions workflows.
Visit [adevinta/lava-action][lava-action] for usage instructions.

## Documentation

Lava is self-documented.
Please run `lava help` to get more information about the available
commands and other related topics.

## Contributing

**This project is in an early stage, we are not accepting external
contributions yet.**

To contribute, please read the [contribution
guidelines][contributing].


[vulcan-docs]: https://adevinta.github.io/vulcan-docs
[vulcan-checks]: https://github.com/adevinta/vulcan-checks
[lava-action]: https://github.com/adevinta/lava-action
[contributing]: /CONTRIBUTING.md

0 comments on commit ec9ba34

Please sign in to comment.