Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/config: fix inconsistencies in tests #97

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

jroimartin
Copy link
Contributor

This PR fixes several inconsistencies in test names. It also
simplifies some tests.

@jroimartin jroimartin requested a review from seilagamo January 23, 2025 16:41
@jroimartin jroimartin changed the title internal/config: fix inconsistencies internal/config: fix inconsistencies in tests Jan 23, 2025
Copy link
Collaborator

@seilagamo seilagamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jroimartin jroimartin merged commit 51e9814 into main Jan 24, 2025
6 checks passed
@jroimartin jroimartin deleted the config-tests branch January 24, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants