Improve secret name to allow non trailing slash in path

adevinta · Apr 3, 2024 · 1fb4703 · 1fb4703
1 parent 0f5c3e5
commit 1fb4703
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/secrets/secrets.go b/pkg/secrets/secrets.go
@@ -9,6 +9,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"path/filepath"
 
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/session"
@@ -62,8 +63,7 @@ func NewAWSSecretManager(config config.AwsConfig, logger echo.Logger) (*AWSSecre
 // GetServerCredentials return the Jira credentials inside a Credentials type
 // from AWS secret manager for a specific server.
 func (s *AWSSecrets) GetServerCredentials(serverID string) (Credentials, error) {
-	secretName := fmt.Sprintf("%s%s", s.config.ServerCredentialsKey, serverID)
-
+	secretName := filepath.Join(s.config.ServerCredentialsKey, serverID)
 	result, err := s.secretCache.GetSecretString(secretName)
 	if err != nil {
 		return Credentials{}, &vterrors.TrackingError{