Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: add golangci.yaml and fix errors #28

Merged
merged 1 commit into from
Mar 21, 2024
Merged

all: add golangci.yaml and fix errors #28

merged 1 commit into from
Mar 21, 2024

Conversation

seilagamo
Copy link
Collaborator

@seilagamo seilagamo commented Mar 5, 2024

Add golangci.yaml to the project and fix all the errors to stop golangci complaints about the code.

@seilagamo seilagamo marked this pull request as draft March 21, 2024 08:09
@seilagamo seilagamo marked this pull request as ready for review March 21, 2024 10:23
@seilagamo seilagamo requested a review from jesusfcr March 21, 2024 10:24
Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion

.gitignore Show resolved Hide resolved
Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seilagamo seilagamo merged commit f1ea79c into master Mar 21, 2024
5 checks passed
@seilagamo seilagamo deleted the golangci branch March 21, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants