[ENG-4591] Barium/upgrade ember 3.28 (CenterForOpenScience#1899)

## Purpose

Upgrade ember to 3.28

## Summary of Changes

1. Match ember dependencies to `ember new` blueprint
2. Fix all the problems
3. Modify getApiErrorMessage to re-throw in the case of no API error message

(some problems fixed h/t @futa-ikeda)

.eslintignore

@@ -18,6 +18,7 @@
 # misc
 /coverage/
 !.*
+.*/
 .eslintcache
 
 # ember-try

.eslintrc.js

@@ -282,52 +282,60 @@ module.exports = {
             },
         },
         {
-            files: ['app/locales/*/translations.ts'],
+            files: ['./app/locales/*/translations.ts'],
             rules: {
                 'max-len': 'off',
             },
         },
         {
-            files: ['tests/**/*'],
+            files: ['./tests/**/*'],
             rules: {
                 'no-await-in-loop': 'off',
                 'ember/avoid-leaking-state-in-components': 'off',
                 'ember/avoid-leaking-state-in-ember-objects': 'off',
             },
         },
         {
-            files: ['mirage/**/*'],
+            // Test files:
+            files: ['tests/**/*-test.{js,ts}'],
+            extends: ['plugin:qunit/recommended'],
+            rules: {
+                'qunit/require-expect': 'off',
+            },
+        },
+        {
+            files: ['./mirage/**/*'],
             rules: {
                 'ember/avoid-leaking-state-in-ember-objects': 'off',
             },
         },
         {
-            files: ['lib/*/index.js'],
+            files: ['./lib/*/index.js'],
             rules: {
                 'ember/avoid-leaking-state-in-ember-objects': 'off',
                 '@typescript-eslint/no-var-requires': 'off',
             },
         },
         {
-            files: ['lib/*/addon/engine.js'],
+            files: ['./lib/*/addon/engine.js'],
             rules: {
                 'ember/avoid-leaking-state-in-ember-objects': 'off',
             },
         },
         {
             files: [
-                '.eslintrc.js',
-                '.prettierrc.js',
-                '.template-lintrc.js',
-                'ember-cli-build.js',
-                'testem.js',
-                'run-node-test.js',
-                'lib/**/environment.js',
-                'lib/**/index.js',
-                'blueprints/*/index.js',
-                'blueprints/**/*.js',
-                'node-tests/**/*.js',
-                'config/**/*.js',
+                './.eslintrc.js',
+                './.prettierrc.js',
+                './.template-lintrc.js',
+                './ember-cli-build.js',
+                './testem.js',
+                './run-node-test.js',
+                './lib/**/environment.js',
+                './lib/**/index.js',
+                './blueprints/*/index.js',
+                './blueprints/**/*.js',
+                './node-tests/**/*.js',
+                './config/**/*.js',
             ],
             parserOptions: {
                 sourceType: 'script',

.template-lintrc.js

@@ -3,7 +3,7 @@
 'use strict';
 
 module.exports = {
-    extends: 'octane',
+    extends: 'recommended',
 
     rules: {
         'block-indentation': 4,

app/adapters/node.ts

@@ -4,7 +4,7 @@ import OsfAdapter from './osf-adapter';
 export default class NodeAdapter extends OsfAdapter {
     buildURL(modelName?: string | number, id?: string, snapshot?: DS.Snapshot | null, requestType?: string): string {
         if (snapshot && requestType === 'createRecord') {
-            const parent: any = snapshot.record.belongsTo('parent').belongsToRelationship.members.list[0];
+            const parent: any = snapshot.record.belongsTo('parent').belongsToRelationship.members?.list[0];
 
             if (parent) {
                 return this.buildRelationshipURL(parent.createSnapshot(), 'children');

app/guid-file/route.ts

@@ -1,6 +1,7 @@
 import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
 import { waitFor } from '@ember/test-waiters';
+import Store from '@ember-data/store';
 import HeadTagsService from 'ember-cli-meta-tags/services/head-tags';
 import { task } from 'ember-concurrency';
 import { taskFor } from 'ember-concurrency-ts';
@@ -32,6 +33,7 @@ export default class GuidFile extends Route {
     @service metaTags!: MetaTags;
     @service ready!: Ready;
     @service currentUser!: CurrentUserService;
+    @service store!: Store;
 
     headTags?: HeadTagDef[];
     metadata!: CustomFileMetadataRecordModel;

app/institutions/dashboard/route.ts

@@ -2,6 +2,7 @@ import Route from '@ember/routing/route';
 import RouterService from '@ember/routing/router-service';
 import { inject as service } from '@ember/service';
 import { waitFor } from '@ember/test-waiters';
+import Store from '@ember-data/store';
 import { task } from 'ember-concurrency';
 import { taskFor } from 'ember-concurrency-ts';
 
@@ -18,6 +19,7 @@ export interface InstitutionsDashboardModel {
 }
 export default class InstitutionsDashboardRoute extends Route {
     @service router!: RouterService;
+    @service store!: Store;
 
     @task
     @waitFor

app/meetings/detail/route.ts

@@ -2,11 +2,13 @@ import Route from '@ember/routing/route';
 import RouterService from '@ember/routing/router-service';
 import { inject as service } from '@ember/service';
 import { waitFor } from '@ember/test-waiters';
+import Store from '@ember-data/store';
 import { task } from 'ember-concurrency';
 import { taskFor } from 'ember-concurrency-ts';
 
 export default class MeetingsDetail extends Route {
     @service router!: RouterService;
+    @service store!: Store;
 
     @task
     @waitFor

app/models/abstract-node.ts

@@ -7,7 +7,7 @@ import FileProviderModel from 'ember-osf-web/models/file-provider';
 import { Permission } from './osf-model';
 
 export default class AbstractNodeModel extends BaseFileItem {
-    @hasMany('file-provider', { inverse: 'target' })
+    @hasMany('file-provider', { inverse: 'target', polymorphic: true })
     files!: AsyncHasMany<FileProviderModel> & FileProviderModel[];
 
     @hasMany('draft-registration', { inverse: 'branchedFrom' })

app/models/file-provider.ts

@@ -16,10 +16,10 @@ export default class FileProviderModel extends BaseFileItem {
     @attr('string') path!: string;
     @attr('fixstring') provider!: string;
 
-    @belongsTo('file')
+    @belongsTo('base-file-item', { polymorphic: true })
     rootFolder!: AsyncBelongsTo<FileModel> & FileModel;
 
-    @hasMany('file', { inverse: 'parentFolder' })
+    @hasMany('file', { polymorphic: true })
     files!: AsyncHasMany<FileModel>;
 
     @belongsTo('abstract-node', { inverse: 'files', polymorphic: true })

app/models/file.ts

@@ -42,7 +42,7 @@ export default class FileModel extends BaseFileItem {
     @attr('fixstring') checkout!: string;
     @attr('boolean') showAsUnviewed!: boolean;
 
-    @belongsTo('file', { inverse: 'files' })
+    @belongsTo('file', { inverse: 'files', polymorphic: true })
     parentFolder!: AsyncBelongsTo<FileModel> & FileModel;
 
     // Folder attributes

app/models/node.ts

@@ -147,7 +147,7 @@ export default class NodeModel extends AbstractNodeModel.extend(Validations, Col
     @hasMany('registration', { inverse: 'registeredFrom' })
     registrations!: AsyncHasMany<RegistrationModel>;
 
-    @hasMany('node', { inverse: 'forkedFrom' })
+    @hasMany('node', { inverse: 'forkedFrom', polymorphic: true })
     forks!: AsyncHasMany<NodeModel>;
 
     @belongsTo('node', { inverse: 'forks', polymorphic: true })

app/register/route.ts

@@ -1,11 +1,14 @@
 import Transition from '@ember/routing/-private/transition';
 import Route from '@ember/routing/route';
 import { inject as service } from '@ember/service';
+import Store from '@ember-data/store';
+
 import Session from 'ember-simple-auth/services/session';
 
 
 export default class Register extends Route {
     @service session!: Session;
+    @service store!: Store;
 
     async beforeModel(transition: Transition) {
         await super.beforeModel(transition);

app/serializers/file.ts

@@ -7,6 +7,9 @@ import OsfSerializer from './osf-serializer';
 export default class FileSerializer extends OsfSerializer {
     normalize(modelClass: FileModel, resourceHash: Resource) {
         const hash = resourceHash;
+        if (hash.relationships?.root_folder) {
+            hash.type = 'file-providers';
+        }
         const checkoutRel = hash.relationships!.checkout;
         if (checkoutRel && 'links' in checkoutRel) {
             const { related } = checkoutRel.links;

app/serializers/osf-serializer.ts

@@ -138,7 +138,7 @@ export default class OsfSerializer extends JSONAPISerializer {
 
         const includeCleanData = options && options.osf && options.osf.includeCleanData;
         if (!includeCleanData && !snapshot.record.get('isNew')) {
-            // Only send dirty attributes and relationships in request
+            // Only send dirty attributes in request
             const changedAttributes = snapshot.record.changedAttributes();
             for (const attribute of Object.keys(serialized.data.attributes!)) {
                 const { attrs }: { attrs: any } = this;
@@ -147,19 +147,6 @@ export default class OsfSerializer extends JSONAPISerializer {
                     delete serialized.data.attributes![attribute];
                 }
             }
-            // HACK: There's no public-API way to tell whether a relationship has been changed.
-            const relationships = (snapshot as any)._internalModel.__recordData._relationships.initializedRelationships;
-            if (serialized.data.relationships) {
-                for (const key of Object.keys(serialized.data.relationships)) {
-                    const rel = relationships[camelize(key)];
-                    if (rel
-                        && rel.members.list.length === rel.canonicalMembers.list.length
-                        && rel.members.list.every((v: any, i: any) => v === rel.canonicalMembers.list[i])
-                    ) {
-                        delete serialized.data.relationships[key];
-                    }
-                }
-            }
         }
 
         return serialized;

app/settings/developer-apps/create/route.ts

@@ -1,7 +1,11 @@
 import Route from '@ember/routing/route';
+import { inject as service } from '@ember/service';
+import Store from '@ember-data/store';
 import SettingsApplicationCreateController from './controller';
 
 export default class SettingsDeveloperAppsCreateRoute extends Route {
+    @service store!: Store;
+
     setupController(controller: SettingsApplicationCreateController) {
         controller.set('developerApp', this.store.createRecord('developer-app'));
     }

app/settings/developer-apps/edit/route.ts

@@ -2,13 +2,15 @@ import Route from '@ember/routing/route';
 import RouterService from '@ember/routing/router-service';
 import { inject as service } from '@ember/service';
 import { waitFor } from '@ember/test-waiters';
+import Store from '@ember-data/store';
 import { task } from 'ember-concurrency';
 import { taskFor } from 'ember-concurrency-ts';
 
 import { notFoundURL } from 'ember-osf-web/utils/clean-url';
 
 export default class SettingsDeveloperAppsEditRoute extends Route {
     @service router!: RouterService;
+    @service store!: Store;
 
     @task
     @waitFor

app/settings/tokens/edit/route.ts

@@ -3,6 +3,7 @@ import Route from '@ember/routing/route';
 import RouterService from '@ember/routing/router-service';
 import { inject as service } from '@ember/service';
 import { waitFor } from '@ember/test-waiters';
+import Store from '@ember-data/store';
 import { task } from 'ember-concurrency';
 import { taskFor } from 'ember-concurrency-ts';
 
@@ -12,6 +13,7 @@ import SettingsTokensEditController from './controller';
 
 export default class SettingsTokensEditRoute extends Route {
     @service router!: RouterService;
+    @service store!: Store;
 
     @task
     @waitFor

app/utils/capture-exception.ts

@@ -32,7 +32,10 @@ export function getApiError(error: ErrorDocument): ErrorObject|undefined {
 
 export function getApiErrorMessage(error: ErrorDocument): string {
     const apiError = getApiError(error);
-    return (apiError && apiError.detail) ? apiError.detail : '';
+    if(apiError){
+        return (apiError && apiError.detail) ? apiError.detail : '';
+    }
+    throw error;
 }
 
 export function getApiErrors(error: ErrorDocument): Record<string, ErrorObject> {

bin/run-node-test.js

@@ -1,11 +1,12 @@
 'use strict';
 
-const Mocha = require('mocha');
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const Mocha = require('mocha'); // eslint-disable-line no-undef
 
-const test = process.argv[2];
+const test = process.argv[2]; // eslint-disable-line no-undef
 
 // Run the mocha test.
 const mocha = new Mocha();
 mocha.addFile(`node-tests/${test}-test.js`);
 // eslint-disable-next-line no-process-exit
-mocha.run(failures => process.on('exit', () => process.exit(failures)));
+mocha.run(failures => process.on('exit', () => process.exit(failures))); // eslint-disable-line no-undef

config/deprecation-workflow.js

@@ -11,5 +11,18 @@ self.deprecationWorkflow.config = {
         { handler: 'silence', matchId: 'ember-cli-mirage-config-routes-only-export' },
         { handler: 'silence', matchId: 'ember-engines.deprecation-router-service-from-host'},
         { handler: 'silence', matchId: 'ember-test-waiters-legacy-module-name'},
+        { handler: 'silence', matchId: 'argument-less-helper-paren-less-invocation'},
+        { handler: 'silence', matchId: 'deprecated-run-loop-and-computed-dot-access'},
+        { handler: 'silence', matchId: 'ember.built-in-components.import'},
+        { handler: 'silence', matchId: 'ember.built-in-components.legacy-arguments'},
+        { handler: 'silence', matchId: 'ember.built-in-components.legacy-attribute-arguments'},
+        { handler: 'silence', matchId: 'ember.built-in-components.reopen'},
+        { handler: 'silence', matchId: 'ember.component.reopen'},
+        { handler: 'silence', matchId: 'ember-global'},
+        { handler: 'silence', matchId: 'ember.link-to.disabled-when'},
+        { handler: 'silence', matchId: 'route-disconnect-outlet'},
+        { handler: 'silence', matchId: 'route-render-template'},
+        { handler: 'silence', matchId: 'template-compiler.registerPlugin'},
+        { handler: 'silence', matchId: 'setting-on-hash'},
     ],
 };

config/ember-cli-update.json

@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "3.26.1",
+      "version": "3.28.6",
       "blueprints": [
         {
           "name": "app",

config/targets.js

@@ -6,12 +6,20 @@ const browsers = [
     'last 1 Safari versions',
 ];
 
-const isCI = Boolean(process.env.CI);
-const isProduction = process.env.EMBER_ENV === 'production';
-
-if (isCI || isProduction) {
-    // browsers.push('ie 11');
-}
+// Ember's browser support policy is changing, and IE11 support will end in
+// v4.0 onwards.
+//
+// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
+//
+// If you need IE11 support on a version of Ember that still offers support
+// for it, uncomment the code block below.
+//
+// const isCI = Boolean(process.env.CI);
+// const isProduction = process.env.EMBER_ENV === 'production';
+//
+// if (isCI || isProduction) {
+//   browsers.push('ie 11');
+// }
 
 module.exports = {
     browsers,