reorganize footer into 2 columns + icons for social links #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <li><a href="http://www.adobe.com/privacy.html?mboxsession=1408569095591-255580" target="_blank">Privacy Policy</a></li> | ||
| </ul> | ||
| <h3>Learn More</h3> | ||
| <table> |
There was a problem hiding this comment.
Probably shouldn't use a table for non-tabular data. You can use floats, inline-blocks, or display: table, but the
element has semantic meaning attached.…ved cruft from svg files
|
@betravis - Made your suggested changes in the latest commit. |
|
Merging, but this emphasizes #59 (small touch targets for footer), so we will need to fix that up soon as well. |
betravis
added a commit
that referenced
this pull request
Oct 30, 2014
reorganize footer into 2 columns + icons for social links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #154
@JuleeAtAdobe @betravis r?
Here's a preview of the change on the right next to how it is currently.