Skip to content

Commit

Permalink
Fix popover tips in FF (#5040)
Browse files Browse the repository at this point in the history
  • Loading branch information
snowystinger authored Sep 7, 2023
1 parent 0114c97 commit c82b531
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/@react-aria/overlays/docs/usePopover.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ function Popover({children, state, offset = 8, ...props}: PopoverProps) {
{...popoverProps}
ref={popoverRef}
className="popover">
<svg {...arrowProps} className="arrow" data-placement={placement}>
<path d="M0 0,L6 6,L12 0" />
<svg {...arrowProps} className="arrow" data-placement={placement} viewBox="0 0 12 12">
<path d="M0 0 L6 6 L12 0" />
</svg>
<DismissButton onDismiss={state.close} />
{children}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-aria-components/docs/Popover.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import {DialogTrigger, Popover, Dialog, Button, OverlayArrow} from 'react-aria-c
<Button>Open popover</Button>
<Popover>
<OverlayArrow>
<svg width={12} height={12}><path d="M0 0,L6 6,L12 0" /></svg>
<svg width={12} height={12} viewBox="0 0 12 12"><path d="M0 0 L6 6 L12 0" /></svg>
</OverlayArrow>
<Dialog>
This is a popover.
Expand Down Expand Up @@ -219,7 +219,7 @@ function MyPopover({children, ...props}: MyPopoverProps) {
return (
<Popover {...props}>
<OverlayArrow>
<svg width={12} height={12}><path d="M0 0,L6 6,L12 0" /></svg>
<svg width={12} height={12} viewBox="0 0 12 12"><path d="M0 0 L6 6 L12 0" /></svg>
</OverlayArrow>
<Dialog>
{children}
Expand Down

1 comment on commit c82b531

@rspbot
Copy link

@rspbot rspbot commented on c82b531 Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.