Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add rss feed to release notes and blog posts #7534

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Dec 17, 2024

Closes #2735

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Go to docs (https://reactspectrum.blob.core.windows.net/reactspectrum/14d0503c145e47fda931d7931b0eca5544ea01a0/verdaccio/docs/index.html)
  2. Go to either our release notes or blog posts and scroll to the button
  3. Click on the RSS Link which should open a new tab
  4. If you want, you can try subscribing to that url in some aggregator and see how it looks

🧢 Your Project:

@yihuiliao yihuiliao changed the title Add rss feed wip: Add rss feed Dec 17, 2024
@rspbot
Copy link

rspbot commented Dec 17, 2024

@rspbot
Copy link

rspbot commented Dec 17, 2024

@rspbot
Copy link

rspbot commented Dec 17, 2024

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@yihuiliao yihuiliao changed the title wip: Add rss feed docs: add rss feed to release notes and blog posts Dec 19, 2024
@yihuiliao yihuiliao marked this pull request as ready for review December 19, 2024 18:20
@rspbot
Copy link

rspbot commented Dec 19, 2024

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, otherwise looks good

package.json Outdated Show resolved Hide resolved
scripts/createFeed.mjs Outdated Show resolved Hide resolved
scripts/createFeed.mjs Outdated Show resolved Hide resolved
@adobe adobe deleted a comment from rspbot Dec 19, 2024
@adobe adobe deleted a comment from rspbot Dec 23, 2024
@rspbot
Copy link

rspbot commented Dec 23, 2024

@adobe adobe deleted a comment from rspbot Jan 2, 2025
Comment on lines +52 to +62
{"atom:link": {
_attr: {
href: `https://react-spectrum.adobe.com/${type}/${type}-feed.rss`,
rel: "self",
type: "application/rss+xml",
},
},
},
{title: "Adobe React Spectrum"},
{link: `https://react-spectrum.adobe.com/`},
{description: "A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences."},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the details here be made more specific to "releases"/"blog posts"? At the moment when I subscribe to these feed via an aggregator, they both come up as "Adobe React Spectrum". Alternatively, perhaps they both should be merged under a single feed so you get both the release and blog posts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide changelog and notifications for new releases
5 participants