Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement newly designed post download page #736

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Jan 28, 2025

Description of change

Adds the new page and fixes a few build warnings

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@gdams gdams linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit c75559a
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/6798eebed553be00087bd579
😎 Deploy Preview https://deploy-preview-736--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (eaf9190) to head (c75559a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...rc/components/Marketplace/AllReleaseCard/index.tsx 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   82.36%   82.35%   -0.02%     
==========================================
  Files         145      149       +4     
  Lines       10780    10828      +48     
  Branches      829      835       +6     
==========================================
+ Hits         8879     8917      +38     
- Misses       1901     1911      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdams gdams force-pushed the postdownload branch 4 times, most recently from 54802be to 6de9f8d Compare January 28, 2025 12:47
@gdams gdams merged commit 6800256 into adoptium:main Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Thank You For Downloading Page
2 participants