Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/103 add support for next forecast by remark #107

Conversation

fkrauthan
Copy link
Contributor

Added support to parse the NXT FCST BY remark often found in canadian TAFs. This effectively fixes #103

Copy link
Owner

@aeharding aeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly nits, I'm curious if you could try to get a RemarkDated type made for smarter types!

src/command/remark/NextForecastByCommand.ts Show resolved Hide resolved
src/dates/metar.ts Outdated Show resolved Hide resolved
src/command/remark/NextForecastByCommand.ts Show resolved Hide resolved
src/dates/taf.ts Outdated Show resolved Hide resolved
@fkrauthan fkrauthan requested a review from aeharding January 2, 2025 03:42
Copy link
Owner

@aeharding aeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RemarkDated works great, thanks!

src/command/remark.ts Outdated Show resolved Hide resolved
src/command/remark.ts Show resolved Hide resolved
@aeharding aeharding merged commit 6a89fdd into aeharding:main Jan 2, 2025
1 check passed
@aeharding
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Canadian TAF next forecast remark
2 participants