-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a functional Makefile #96
base: master
Are you sure you want to change the base?
Conversation
Adds a simple makefile to standardize development
Looks fine. In addition, do you see any way to use the normal not docker release of the server? Maybe building the server from a custom dockerfile. |
I had actually thought about adding a port variable initially, but then rejected it because:
At that point, I wondered if there was really much sense in adding a port variable. That said I do want to make another update to the Makefile, so if you think there's enough of a good reason despite the above 4, I'm not opposed to adding it. |
No you are right. I didnt think about just overwriting the whole variable. Thats perfectly fine. |
The makefile will now read a dotenv file if present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I think adding a Makefile with standarized commands to build, test, release the client is a great idea.
I took your thoughts and made several port environment variables using: https://www.aerospike.com/docs/operations/configure/network/ At this point you can now override where they are resolved locally. |
* Makes env command available in the help menu * Removes help from the menu * Adds env to run when a release command is run * Reduces menu width
Each feature should be tested individually to determine if the code works with and without the feature running.
Adds a simple Makefile to standardize development
Addresses #95.