Update data.yml, Add AgentInventoryContext::InventoryContextEvent #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfcomp
reviewed
Jan 14, 2025
| [GenerateInterop] | ||
| [Inherits<EventHandler>] | ||
| [Inherits<EventHandler>, Inherits<AgentInventoryContext.InventoryContextEvent>] |
There was a problem hiding this comment.
This seems to have a 3rd inheritance that is calling stuff related to Client::Game::Event::FinalizeSceneTask 2 layers deep in vf1 of said inheritance. Not sure if you want to investigate this before merge.
There was a problem hiding this comment.
Yeah I know, says so in the comments at the start of the struct.
But I didn't want to look into it, because I didn't want to come up with a name. 😅
There was a problem hiding this comment.
ShopSceneTaskScheduler 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for inheritance. Didn't look into what it does.
But I noticed that the ctor for
AgentAquariumSettingsets it vtable to +8. Not sure what's going on there, doesn't make sense.