Handle circuit breaker rollbacks #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claude-GP
approved these changes
Jan 4, 2024
| core.info(`A new PRIMARY deployment is registered with task definition ${primaryDeployment.taskDefinitionArn}.`); | ||
| return DeploymentOutcome.SKIPPED; | ||
| } else if (isServiceStable(clusterName, serviceName)) { | ||
| } else if (primaryDeployment.taskDefinitionArn !== taskDefinitionArn && newTaskDefinitionRevision < previousTaskDefinitionRevision) { | ||
| core.error(`A rollback has been triggered. Starting a new deployment with task definition ${primaryDeployment.taskDefinitionArn}.`); |
There was a problem hiding this comment.
Juste pour bien comprendre circuit breaker, quand un rollback est trigger, il rollback au dernier déploiement COMPLETED et ne redéploie pas de container?
There was a problem hiding this comment.
il rollback au dernier déploiement COMPLETED
Oui exact
et ne redéploie pas de container?
Ca dépend, si pour une raison X, disons 25% containers avaient réussit à tombé healthy. Alors lors du rollback il va devoir redéployé certains containers pour honorer les desired count du service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to handle ECS circuit breaker rollbacks
The ECS circuit breaker rollback to a previous task definition revision. When this happens, we want our action to fail in order to alert us
En activant ce feature, nous pouvons retirer l'étape de rollback dans le CI/CD