fix(#2008): Changes GoogleSearch to GoogleSearchTools #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s deprecation warning for GoogleSearch class
Comment on lines
+92
to
+118
| class GoogleSearch(GoogleSearchTools): | ||
| """ | ||
| Deprecated: Use `GoogleSearchTools` instead. | ||
|
|
||
| This class is maintained for backward compatibility and will be removed in a future version. | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| fixed_max_results: Optional[int] = None, | ||
| fixed_language: Optional[str] = None, | ||
| headers: Optional[Any] = None, | ||
| proxy: Optional[str] = None, | ||
| timeout: Optional[int] = 10, | ||
| ): | ||
| warnings.warn( | ||
| "GoogleSearch class is deprecated. Please use `GoogleSearchTools` instead.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) | ||
| super().__init__( | ||
| fixed_max_results=fixed_max_results, | ||
| fixed_language=fixed_language, | ||
| headers=headers, | ||
| proxy=proxy, | ||
| timeout=timeout, | ||
| ) |
There was a problem hiding this comment.
We can skip class. Were you trying to have backward compatibility?
There was a problem hiding this comment.
Yes i was keeping backward compatibility so that we can release it in a patch update instead of a major update
|
Thank you @Harsh-2909, for taking this issue up and opening a PR to resolve the issue. But this is a duplicate PR as its already tackled in #2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # 2008
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).