Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of the use case side of the Solutions pillar #2709

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Conversation

jacobdadams
Copy link
Member

@jacobdadams jacobdadams commented Mar 26, 2024

There were a couple noticable problems (periods in the wrong spot, the wrong section title for the Integrating GIS page). However, most of this is me getting fully stuck into copy-editor mode and trying to unify voice and make things more concise and less repetitive. I realize I'm changing a lot of people's words, so feel free to push back and reject changes if I've missed the mark.

Copy link

request-info bot commented Mar 26, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for gis-utah-gov ready!

Name Link
🔨 Latest commit d68d77a
🔍 Latest deploy log https://app.netlify.com/sites/gis-utah-gov/deploys/6606eb05e8761b0008f813a0
😎 Deploy Preview https://deploy-preview-2709--gis-utah-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacobdadams jacobdadams changed the title r Review of the use case side of the Solutions pillar Mar 26, 2024
@jacobdadams jacobdadams marked this pull request as ready for review March 26, 2024 21:02
steveoh
steveoh previously approved these changes Mar 26, 2024
@steveoh
Copy link
Member

steveoh commented Mar 28, 2024

I'll merge this COB tomorrow to give folks another day to check it out.

Copy link
Contributor

@nathankota nathankota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly glossed over the 911 and network content, and paid much greater attention to the other sections. Besides a few comments that I trust your judgement to accept or ignore, I support the changes.
Good night Westley. Good work. Sleep well. I'll most likely kill you in the morning 😆

src/pages/solutions/gis-strategy.astro Outdated Show resolved Hide resolved
src/pages/solutions/gis-strategy.astro Show resolved Hide resolved
src/pages/solutions/spatial-data-management.astro Outdated Show resolved Hide resolved
@steveoh steveoh enabled auto-merge (rebase) April 1, 2024 16:53
@steveoh steveoh merged commit 1eb4616 into main Apr 1, 2024
6 checks passed
@steveoh steveoh deleted the review-usecase branch April 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants