Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates for print proxy v2 #2775

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: updates for print proxy v2 #2775

merged 1 commit into from
Jul 16, 2024

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Jun 4, 2024 •
edited
Loading

Waiting on the production release of Print Proxy v2 for these changes.

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for gis-utah-gov ready!

Name Link
🔨 Latest commit 16a1bbe
🔍 Latest deploy log https://app.netlify.com/sites/gis-utah-gov/deploys/6696a70fd7b2470008c0d6e5
😎 Deploy Preview https://deploy-preview-2775--gis-utah-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@stdavis stdavis mentioned this pull request Jun 6, 2024
Closed
1 task
@stdavis stdavis marked this pull request as ready for review July 16, 2024 17:00
@stdavis stdavis enabled auto-merge (rebase) July 16, 2024 17:00
@stdavis stdavis merged commit dd1dd6c into main Jul 16, 2024
6 checks passed
@stdavis stdavis deleted the fix/print-proxy branch July 16, 2024 17:02
steveoh
steveoh reviewed Jul 16, 2024
View reviewed changes
src/data/contacts.ts
Comment on lines -422 to -426
print_proxy: {
name: 'Scott Davis',
agency: 'UGRC',
email: '[email protected]',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reasoning to pull out of here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I had everything going to [email protected] for print proxy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you ok with using the contact component and updating the contacts to point to the generic ugrc developers? We have a "rule" not to have mailto links in pages.

I think we should consolidate our work emails for the group in other places. I can put together that pull request if you're happy with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that the mailto rule applied to generic accounts but I'm good with that. I'll submit a quick PR to fix this page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. https://github.com/agrc/gis.utah.gov#contact-information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveoh steveoh steveoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stdavis @steveoh