Throw invoke errors

[vixalien]

By default, only the message Error invoking method ${methodName} is logged when invoking an error. This PR logs throws the GLib.Error correctly if an error happened while executing a function.

I'm creating this as a draft PR because I think the better approach is to throw the GLib.Error (hence interrupting control flow), but I'm still thinking about creating a GLib.Error done

[ahgilak]

I think it's not a good idea to use introspection inside deno_gi as it can lead to recursive dependency on it's self.
is it possible to do this with only using static bindings?

[vixalien]

I don't think it's the best idea ever, but it's the best approach.

This is because the GLib.Error must be consistent with other instances of GLib.Error so that we can do instance checks like so:

try {
  const file = Glib.file_get_contents("/path/to");
} catch (err) {
  if (err instanceof GLib.Error && error.matches(GLib.FileError.NOENT)) {
	  console.error("The file was not found");
  } else {
     //... handle error differently
  }
}

The above code would not work otherwise because GLib.Error would be a completely different instance from error.

[ahgilak]

okay that makes sense

[vixalien]

That said, do you think it's a good idea to cache repos, so that require(lib, version) always returns the same exact Object instead of creating new ones each time?

This would allow for overriding methods across all imported repos, for example: GLib.Error.toString would be overridden (maybe in #10) and all errors would be overridden at once.

[vixalien]

createGError should also handle when there is no error, and log that an error happened while trying to invoke the function, as before.

[ahgilak]

That said, do you think it's a good idea to cache repos, so that require(lib, version) always returns the same exact Object instead of creating new ones each time?

Yeah it's good to cache repos.

[ahgilak]

creating key this way is not suitable.
if version is not passed, latest version of library available on the system will be loaded, so for example

require("GLib");
require("GLib", "2.0");

should be the same.

[vixalien]

if version is not passed, latest version of library available on the system will be loaded, so for example

If the version is not passed, the latest version will always be loaded, which makes the cache return the latest version and the behaviour is correct. What we can do is like GJS, and warn if there are multiple library versions.

Maybe to make the code correct, we can list all the versions and automatically load the latest one.

gjs> imports.gi.Gtk
typein:1:1 warning: Requiring Gtk but it has 2 versions available; use imports.gi.versions to pick one
[object GIRepositoryNamespace]

[vixalien]

I've updated the code to handle the above scenario, please take a look if you can.

[ahgilak]

LGTM. Thanks.

[ahgilak]

I rebased it on main. is this ready to merge now?

[vixalien]

Thanks, I just added the code to throw a generic error like Error invoking constructor {name} when a function invocation does not succeed but without an error.

Ready for re-review